-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed test to use lower case names consistent with PVA #22
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## dev #22 +/- ##
=======================================
Coverage 83.50% 83.50%
=======================================
Files 7 7
Lines 1073 1073
=======================================
Hits 896 896
Misses 177 177
☔ View full report in Codecov by Sentry. |
Is this a correct understanding of the situation? We create a series of records for the tables, and we pass in the name of each column as an extra bit of info. As PandA returns that name in capitals, we pass it in like that, but then PVI is internally converting it to lower case? Is that an expected behaviour? It seems like an odd bit of unnecessary work that it's doing. |
@coretl mentioned this maybe he can weight in? I remember hearing that names will be capitalised and made lowercase at different points in the I22 run we're planning |
That is correct, we need the names in the PVI structure, and the names in the PVA table structure to be lowercase, as we tie python attribute names to this in Ophyd... |
Sorry, I don't quite get it: We create the PVI name tags, and we're creating them in uppercase? But then when we receive them through pvget we see lowercase strings? I don't see how Ophyd is related to what I believe is happening entirely inside this codebase? |
In this line I make the PVA table column lowercase:
This makes the same name to the tests. In #18 I also make the PVI structure name lowercase, so that's not actually part of this PR... |
Closes #13